From 06173d288ab32f2f1a61e77b083d92b483b00e77 Mon Sep 17 00:00:00 2001 From: Paul Semel Date: Mon, 9 Dec 2024 23:53:26 +0100 Subject: [PATCH] build_manager: allow remote unpacking when unpacking everything (#4473) Now that we are lazily checking for fuzzing targets, it makes sense to allow remote unpacking even when unpacking the full archive. Furthermore, it seems that remote unpacking performances are much higher than local unpacking on CF bots, so this might improve overall performances of the build_manager. --- .../_internal/build_management/build_manager.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/clusterfuzz/_internal/build_management/build_manager.py b/src/clusterfuzz/_internal/build_management/build_manager.py index 4397e7610a..15dfa794e0 100644 --- a/src/clusterfuzz/_internal/build_management/build_manager.py +++ b/src/clusterfuzz/_internal/build_management/build_manager.py @@ -485,12 +485,11 @@ def _open_build_archive(self, base_build_dir: str, build_dir: str, # if the HTTP URL is compatible with remote unzipping. allow_unpack_over_http = environment.get_value( 'ALLOW_UNPACK_OVER_HTTP', default_value=False) - can_unzip_over_http = ( - allow_unpack_over_http and not self._unpack_everything and - http_build_url and + can_unpack_over_http = ( + allow_unpack_over_http and http_build_url and build_archive.unzip_over_http_compatible(http_build_url)) - if not can_unzip_over_http: + if not can_unpack_over_http: return self._download_and_open_build_archive(base_build_dir, build_dir, build_url) # We do not emmit a metric for build download time, if using http