Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the parallelized mapping outside db transaction #2715

Merged
merged 5 commits into from
Nov 27, 2024

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Nov 8, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Moved the parallized parsing of resources fetched from DB to be done outside the db trnsaction lambda

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

ndegwamartin added a commit to opensrp/android-fhir that referenced this pull request Nov 12, 2024
        FORK
                        - With unmerged PR #9
                        - WUP  #13

        SDK
                        - WUP google#2178
                        - WUP google#2650
                        - WUP google#2663
                        - WUP google#2645
                        - WUP google#2715
@LZRS LZRS marked this pull request as ready for review November 26, 2024 07:34
@LZRS LZRS requested a review from a team as a code owner November 26, 2024 07:34
@LZRS LZRS requested a review from MJ1998 November 26, 2024 07:34
@jingtang10 jingtang10 enabled auto-merge (squash) November 27, 2024 15:50
@jingtang10 jingtang10 merged commit ce5a2f7 into google:master Nov 27, 2024
6 checks passed
@jingtang10 jingtang10 deleted the pmap-refactor branch November 27, 2024 20:28
@jingtang10 jingtang10 linked an issue Nov 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Optimize the Database Search API
4 participants