Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support fhirpath supplement %questionnaire and %qItem literals in expression evaluator #2163

Closed
maimoonak opened this issue Sep 11, 2023 · 2 comments
Labels
P2 Medium priority issue

Comments

@maimoonak
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
To make question fhirpath dynamic and have current questionnaire and item available expression, we need to support fhirpath supplement %questionnaire, and %qItem literal. This allow to get current questionnaire and item into fhirpath expressions on questionnaire items when doing evaluation. Details for spec defined here https://build.fhir.org/ig/HL7/sdc/expressions.html#fhirpath-supplements .

Describe the solution you'd like
Add both literals %questionnaire and %qItem in com.google.android.fhir.datacapture.fhirpath.ExpressionEvaluator#evaluateExpression and ensure that expression evaluation is centralized. Make sure to double check evaluation in enableExpression, and answerExpression if those are implementing their own evaluation instead of using this centralized method.

Linked issue #1849

@jingtang10
Copy link
Collaborator

not sure this is a high priority right now, haven't had any real usecase from any implementers.

should not be difficult to implement either given our existing code structure.

@maimoonak maimoonak mentioned this issue Dec 1, 2023
7 tasks
@f-odhiambo
Copy link
Collaborator

f-odhiambo commented Dec 21, 2023

@jingtang10 should we close this ticket given we have a fix on PR #2346 ?

@github-project-automation github-project-automation bot moved this from New to Complete in Android FHIR SDK Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Medium priority issue
Projects
Status: Complete
Development

No branches or pull requests

3 participants