Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve overriding dimens in SDC #1832

Closed
FikriMilano opened this issue Jan 31, 2023 · 4 comments · Fixed by #1852
Closed

Improve overriding dimens in SDC #1832

FikriMilano opened this issue Jan 31, 2023 · 4 comments · Fixed by #1852
Assignees

Comments

@FikriMilano
Copy link
Collaborator

FikriMilano commented Jan 31, 2023

Is your feature request related to a problem? Please describe.
In client app, I want to override the dimens property to change the margin or padding of the UI components. But if I change a dimens property that is used in the component I like to change, it also affects the other components. Because those dimens property is used in both components.

e.g. padding_default is used as margin top of widgets and padding of check box, overriding this property will affect both, which I don't want to happen.

Describe the solution you'd like
Overriding a dimens property should only affect the component people intend to change.

Describe alternatives you've considered
N/A

Additional context
This is related to the UX Questionnaire adjustments that is ongoing on FHIRCore opensrp/fhircore#1974.

Current design =================> Adjusted design
image image

In summary of our UX changes that depends on SDK:

  • Reduce margin between question and body, should be 16px
  • Add more margin between widgets, should be 32px
  • Reduce margin between selection options, should be 8px

Would you like to work on the issue?
Yeah

@FikriMilano
Copy link
Collaborator Author

@shelaghm @f-odhiambo

@FikriMilano
Copy link
Collaborator Author

@jingtang10 are you going to work on this? or should I?

@jingtang10 jingtang10 moved this from New to In Progress in Android FHIR SDK Feb 14, 2023
@jingtang10 jingtang10 moved this from In Progress to PR under Review in Android FHIR SDK Feb 14, 2023
@jingtang10
Copy link
Collaborator

@santosh-pingle please take a look at this PR!

@jingtang10
Copy link
Collaborator

@shelaghm fyi

@github-project-automation github-project-automation bot moved this from PR under Review to Complete in Android FHIR SDK Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants