-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve overriding dimens in SDC #1832
Comments
@jingtang10 are you going to work on this? or should I? |
This was referenced Feb 3, 2023
@santosh-pingle please take a look at this PR! |
@shelaghm fyi |
github-project-automation
bot
moved this from PR under Review
to Complete
in Android FHIR SDK
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
In client app, I want to override the dimens property to change the margin or padding of the UI components. But if I change a dimens property that is used in the component I like to change, it also affects the other components. Because those dimens property is used in both components.
e.g. padding_default is used as margin top of widgets and padding of check box, overriding this property will affect both, which I don't want to happen.
Describe the solution you'd like
Overriding a dimens property should only affect the component people intend to change.
Describe alternatives you've considered
N/A
Additional context
This is related to the UX Questionnaire adjustments that is ongoing on FHIRCore opensrp/fhircore#1974.
Current design =================> Adjusted design
In summary of our UX changes that depends on SDK:
Would you like to work on the issue?
Yeah
The text was updated successfully, but these errors were encountered: