Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse_server() does not work with pytorch ExportedProgram #231

Closed
Erik-Lundell opened this issue Nov 1, 2024 · 4 comments · Fixed by #245
Closed

reuse_server() does not work with pytorch ExportedProgram #231

Erik-Lundell opened this issue Nov 1, 2024 · 4 comments · Fixed by #245
Assignees
Labels
stat:contribution welcome Status - We are welcoming of any community contributions for this issue type:feature Feature requests

Comments

@Erik-Lundell
Copy link

Hi, very nice application! I noticed that the visualize_pytorch() api was missing a reuse_server option, and tried using visualize_from_config() with add_model_from_pytorch as a workaround. This however fails to send the json generated from the ExportedProgram to the server.

It seems like all parts needed to fix this are in place and I was able to do a hacky-fix where I just added a new field "pytorch_json" to the get/set_transferable data functions in the config and modified the '/api/v1/load_graphs_json' route. Maybe you could make or suggest a better solution? Thanks!

@pkgoogle
Copy link
Contributor

pkgoogle commented Nov 1, 2024

Hi @Erik-Lundell, go ahead and make a PR -- the review will either accept your suggestion or we will make a less hacky fix. Thanks for your help.

@pkgoogle pkgoogle added the stat:contribution welcome Status - We are welcoming of any community contributions for this issue label Nov 1, 2024
@pkgoogle pkgoogle added the type:feature Feature requests label Nov 1, 2024
@jinjingforever jinjingforever self-assigned this Nov 14, 2024
@jinjingforever
Copy link
Collaborator

@Erik-Lundell Actually I have a fix ready and will merge it soon. Thanks for the report!

@jinjingforever
Copy link
Collaborator

This will be released next week. Thanks!

@Erik-Lundell
Copy link
Author

That is great to hear, much appreciated! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:contribution welcome Status - We are welcoming of any community contributions for this issue type:feature Feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants