Skip to content

Commit

Permalink
_content/tour/static/js: fix type errors
Browse files Browse the repository at this point in the history
script.js:694 TypeError: elm.draggable is not a function
    at http://127.0.0.1:3999/tour/script.js:10589:17
    at j (http://127.0.0.1:3999/tour/script.js:675:458)
    at e (http://127.0.0.1:3999/tour/script.js:671:248)
    at e (http://127.0.0.1:3999/tour/script.js:671:265)
    at j (http://127.0.0.1:3999/tour/script.js:675:398)
    at e (http://127.0.0.1:3999/tour/script.js:671:248)
    at http://127.0.0.1:3999/tour/script.js:670:312
    at k (http://127.0.0.1:3999/tour/script.js:782:156)
    at Object.$broadcast (http://127.0.0.1:3999/tour/script.js:722:240)
    at http://127.0.0.1:3999/tour/script.js:714:191 <div vertical-slide="" left="#left-side" right="#right-side">

_content/tour/static/partials/editor.html and _content/tour/static/css
use 'vertical-slide' and 'horizontal-slide'.
I don't know why go.dev does not report these errors.

Change-Id: I9e0f5bb2540af8e642281d7c350f57b69195624a
Reviewed-on: https://go-review.googlesource.com/c/website/+/527080
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Russ Cox <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
  • Loading branch information
hyangah committed Sep 12, 2023
1 parent bc602d6 commit 9a8a0a0
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions _content/tour/static/js/directives.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,12 +74,12 @@ directive('syntaxCheckbox', ['editor',
}
]).

// verticalSlide creates a sliding separator between the left and right elements.
// vertical-slide creates a sliding separator between the left and right elements.
// e.g.:
// <div id="header">Some content</div>
// <div vertical-slide top="#header" bottom="#footer"></div>
// <div id="footer">Some footer</div>
directive('verticalSlide', ['editor',
directive('vertical-slide', ['editor',
function(editor) {
return function(scope, elm, attrs) {
var moveTo = function(x) {
Expand Down Expand Up @@ -113,11 +113,11 @@ directive('verticalSlide', ['editor',
}
]).

// horizontalSlide creates a sliding separator between the top and bottom elements.
// horizontal-slide creates a sliding separator between the top and bottom elements.
// <div id="menu">Some menu</div>
// <div vertical-slide left="#menu" bottom="#content"></div>
// <div id="content">Some content</div>
directive('horizontalSlide', ['editor',
directive('horizontal-slide', ['editor',
function(editor) {
return function(scope, elm, attrs) {
var moveTo = function(y) {
Expand Down

0 comments on commit 9a8a0a0

Please sign in to comment.