fix: event-based replication deletion not work when policy with label #21215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21215 +/- ##
==========================================
+ Coverage 45.36% 46.21% +0.84%
==========================================
Files 244 247 +3
Lines 13333 13863 +530
Branches 2719 2867 +148
==========================================
+ Hits 6049 6407 +358
- Misses 6983 7119 +136
- Partials 301 337 +36
Flags with carried forward coverage won't be shown. Click here to find out more. |
chlins
force-pushed
the
fix/replication-deletion-on-label
branch
from
f0a7b9a
to
39807ae
Compare
chlins
force-pushed
the
fix/replication-deletion-on-label
branch
from
39807ae
to
41576dd
Compare
stonezdj
approved these changes
Nov 25, 2024
chlins
force-pushed
the
fix/replication-deletion-on-label
branch
2 times, most recently
from
777bbc1
to
8c2fdd4
Compare
… filter Fix event-based replication deletion on remote registry not triggered when the replication policy configured the label filter. Signed-off-by: chlins <[email protected]>
chlins
force-pushed
the
fix/replication-deletion-on-label
branch
from
8c2fdd4
to
5757553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix event-based replication deletion on remote registry not triggered when the replication policy configured the label filter.
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #21213
Please indicate you've done the following: