Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtitles cannot be disabled by settings #31

Open
alphanet72 opened this issue Oct 3, 2024 · 2 comments
Open

Subtitles cannot be disabled by settings #31

alphanet72 opened this issue Oct 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@alphanet72
Copy link

Apparently, subtitles are always on, but can be disabled through the telecommand with the [...] key.

@goggle goggle added the bug Something isn't working label Oct 3, 2024
@goggle
Copy link
Owner

goggle commented Oct 4, 2024

So my suggestion to resolve this issue is to remove that option from the plugin's settings.
I think it's not the plugins job to let the user decide if subtitles should be retrieved, because this can be turned of or be disabled elsewhere in Kodi. So if a plugin supports retrieving subtitles, it should always attach them to the video and the user can always opt-out without needing to specify that in the plugin's settings.

By the way, I'm also thinking about removing the option Prefer HD quality, I don't really see the benefits to have this option anymore.

@alphanet72
Copy link
Author

alphanet72 commented Oct 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants