-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix "gf gen pb" api and ctrl not working well. #3076
Conversation
现在只改了个单词错误? |
那就顺便把这些改了 @joy999 |
Only one word mistake has been corrected now? |
Then change these by the way @joy999 |
这个PR还没完成哦~ 还要修改gcmd才算OK。 |
This PR is not completed yet~ You still need to modify gcmd to be OK. |
name:"api" 是name这个tag失效? |
name:"api" is the name tag invalid? |
之前的逻辑只会判定field.Name(),所以不会判定 tag: name,现在给加了如果tag: name存在,则优先使用它进行判定。 |
The previous logic would only determine field.Name(), so tag: name would not be determined. Now it is added that if tag: name exists, it will be used first for determination. |
我看了,改得挺好的,就是缺少对应的单测,麻烦加上对应的单测呢❤️。 |
I took a look, and the changes are pretty good, but the corresponding single test is missing. Could you please add the corresponding single test ❤️. |
No description provided.