Fix Duration options, not taken by env var #135 (#134)

* Add E2E tests also to pull requests

* Fix Duration options, not taken by env var

.github/workflows/build.yml

@@ -24,6 +24,17 @@ jobs:
       # Verify downloaded dependencies
       - name: Verify dependencies
         run: go mod verify
+      - name: "Create k3d Cluster for E2E testing"
+        uses: AbsaOSS/[email protected]
+        with:
+          cluster-name: "testcluster"
+          args: >-
+            -p "8081:80@loadbalancer"
+      - name: "Run E2E tests"
+        run: |
+          k3d kubeconfig merge testcluster --kubeconfig-switch-context
+          KUBECONFIG=~/.k3d/kubeconfig-testcluster.yaml kubectl apply -f ./e2e/k8s/manifest.yml
+          go test -v --tags=e2e
       # Run tests and generates a coverage profile
       - name: Test
         run: |

cli.go

@@ -141,9 +141,10 @@ func getCommandLineOptions() []cli.Flag {
 			case durationType:
 				dv := reflect.ValueOf(defaults).Elem().FieldByName(field.Name).Int()
 				flags = append(flags, cli.DurationFlag{
-					Name:  optName,
-					Usage: usage,
-					Value: time.Duration(dv),
+					Name:   optName,
+					Usage:  usage,
+					Value:  time.Duration(dv),
+					EnvVar: envName,
 				})
 			default:
 				panic("unknown uint64 type in the Config struct")

e2e_test.go

@@ -57,6 +57,8 @@ func TestMain(m *testing.M) {
 		os.Exit(1)
 	}
 
+	time.Sleep(30 * time.Second)
+
 	code := m.Run()
 	os.Exit(code)
 }