Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkipURIs: route parameter support #591

Open
piyongcai opened this issue May 10, 2023 · 2 comments
Open

SkipURIs: route parameter support #591

piyongcai opened this issue May 10, 2023 · 2 comments
Labels
🤔 Question Further information is requested

Comments

@piyongcai
Copy link
Contributor

In fiberzaplog, fiberzerolog middleware, the configuration item SkipURIs only supports equal to comparison. In fact, many routes have parameters, for URL with routing parameters, cannot be effectively excluded by SkipURIs.

All, SkipURIs need to be set to a regular expression or other routing matching pattern to effectively solve this problem.

I hope this feature will be realized soon.

thanks.

@ReneWerner87 ReneWerner87 added 🤔 Question Further information is requested 🧹 Updates and removed 🧹 Updates labels May 10, 2023
@ReneWerner87
Copy link
Member

okay, i didn't notice this feature before, normally it is not needed

Because you can in the Next method which you can pass, his conditions for skipping deposit and also with regex checks perform

@mirusky
Copy link

mirusky commented Aug 31, 2023

Probably deprecate SkipURIs and documentate how to do the same in Next is the best option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 Question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants