Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry - read baggage #400

Open
itziklavon opened this issue Dec 7, 2022 · 6 comments
Open

Opentelemetry - read baggage #400

itziklavon opened this issue Dec 7, 2022 · 6 comments
Labels
🤔 Question Further information is requested

Comments

@itziklavon
Copy link

Hi, are there any changes needs to be done to read the telemetry baggage?
so we would have full flow between services?

currently, if call comes to the server, from a different server which is also using opentelemetry, we cannot see this relation

thanks!

@mstrYoda
Copy link
Member

Hi 👋

The middleware actually does context propagation: https://github.com/gofiber/contrib/blob/main/otelfiber/fiber.go#L100

Can you elaborate your issue?
Do you have any further info to reproduce to see your requirement?

@itziklavon
Copy link
Author

In general, we have 2 applications
both of them monitored via opentelemetry
i have some calls between service A and service B

however, i don't see this full flow via the UI
i mean i do see the calls, from service A -> B
but service B parent trace is Null

might be issue with the way we configure the http client, but i'm not sure
any other configuration needed?
this is the way:

	httpClient.SetTimeout(10 * time.Second)
	httpClient.SetRetryCount(3)
	httpClient.SetTransport(otelhttp.NewTransport(new(RedirectChecker)))
	return httpClient


@ReneWerner87 ReneWerner87 added the 🤔 Question Further information is requested label Mar 29, 2023
@mstrYoda
Copy link
Member

Can you share screenshots?

It should be enough to add otel transport to your http client.

I can see in Jaeger that our applications propagates spans.

@itziklavon
Copy link
Author

Hi, sure
for example:

Service A (gateway - Java based app):
image

Service B (goadmission - go-fiber based app):
image

it is not the same request(it is hard to find the exact request as i don't have anything to link them by), but all request to the path shows in service A going to service B, and it's parent context is null

service A on this case is java (using open telemetry agent)

other services, service A is nodejs and service B is java:
image

in here i see the call from service A (prerouter) to service B (koala-monolith)

@mstrYoda
Copy link
Member

Are you sure about every service's HTTP clients add open telemetry span in their requests?

@itziklavon
Copy link
Author

in this case i'm sure
for example the gateway app from previous example
image

different service, which uses java, does have the proper baggage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤔 Question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants