Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix OccluderPolyShape handles disappear after release click #79947

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #79939

Also checked the 4.0 version. The problem was fixed by replacing this special logic with reworking the EditorPlugin editing logic ;) Since this code is intended to deselect when non-Spatial node is selected, excluding Resource here makes sense.

@timothyqiu timothyqiu added bug topic:editor regression topic:3d cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jul 27, 2023
@timothyqiu timothyqiu added this to the 3.6 milestone Jul 27, 2023
@timothyqiu timothyqiu changed the title Fix OccluderPolyShape handles disappear after release click [3.x] Fix OccluderPolyShape handles disappear after release click Jul 27, 2023
@lawnjelly
Copy link
Member

Just to note, as I understand it:

According to the naming EditorSpatialGizmo the old behaviour kind of makes sense (and was understandable to add). The difficulty is that when editing spatial resources, there's no point duplicating all the functionality which already exists for spatials, so this was reused for the occluder shape resources (there's also a historical element here, they were originally spatials, but then changed to resources as it made more sense for sharing data).

There could also be alternative ways of querying whether something is meant to activate this logic (e.g. a virtual function) if finer grain was needed.

@akien-mga akien-mga merged commit 412e44f into godotengine:3.x Aug 2, 2023
@timothyqiu timothyqiu deleted the edit-resource branch August 2, 2023 15:33
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3. (Together with #80197.)

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants