Add moods (times of day) to Truck Town demo #1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
truck-town-add-moods
branch
from
5b6ff87
to
0bac4dc
Compare
|
We may want to merge #1110 first which includes a bunch of fixes. EDIT: Done. |
Calinou
force-pushed
the
truck-town-add-moods
branch
from
0bac4dc
to
103bb02
Compare
Four moods are available: sunrise, day, sunset, night. Sunset and night also feature artificial point lights placed in the town scene. The mood can be set on the main menu before playing. It can also be cycled during gameplay by pressing M or D-Pad Down.
Calinou
force-pushed
the
truck-town-add-moods
branch
from
103bb02
to
15bcb94
Compare
|
Rebased and tested again, it works as expected. |
aaronfranke
approved these changes
Nov 25, 2024
|
Tested and looked over the changes, looks great! The only thing I'm not sure about is, since this is a substantial and aesthetic change (as opposed to a small bugfix), I would not personally cherrypick this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four moods are available: sunrise, day (default), sunset, night. Sunset and night also feature artificial point lights placed in the town scene.
The mood can be set on the main menu before playing. It can also be cycled during gameplay by pressing M or D-Pad Down.
Tested in all rendering methods. Note that it'll look better in Compatibility once #1132 is merged.
Preview
Sunrise
truck_town_sunrise.mp4
Day
Same appearance as before.
Sunset
truck_town_sunset.mp4
Night
truck_town_night.mp4