Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: function for generating idempotency_key #442

Open
TimBHowe opened this issue Mar 19, 2020 · 3 comments
Open

Feature Request: function for generating idempotency_key #442

TimBHowe opened this issue Mar 19, 2020 · 3 comments
Labels
Needs Reporter Feedabck Issues awaiting for OP feedback Payment Gateway Payment gateway code or issues Proposal Proposals and proof-of-concepts

Comments

@TimBHowe
Copy link

The issue:
We have a site using the WooCommerce Square plugin for a payment gateway that utilize the WooCommerce Plugin Framework. There appears to be an issue where the plugin is using function get_order_with_unique_transaction_ref from wc-plugin-framework/woocommerce/payment-gateway/class-sv-wc-payment-gateway.php to set it's idempotency_key causing double charging in case of false error responses.

Feature Request
We suggest adding a function to the frame work to idempotency_key that can be used by payment gateways that support them such as Square.

@TimBHowe
Copy link
Author

Hey
Been trying to fix the following issues in the WooCommerce Square plugin which uses this plugin framework and thought it would be good to include the generating of an idempotency key here so it can be used in other framework to fix the 2 general problem

https://wordpress.org/support/topic/duplicated-transactions-double-charging-customer/
https://wordpress.org/support/topic/internal_server_error-issues-duplicate-charges-created/
https://wordpress.org/support/topic/idempotency_key-increment-causing-double-charging-in-case-of-false-error-respons/

I have created a pull request #492 and haven't heard back and wanted to check in.

@unfulvio-godaddy unfulvio-godaddy added Payment Gateway Payment gateway code or issues Proposal Proposals and proof-of-concepts Needs Reporter Feedabck Issues awaiting for OP feedback labels Jul 3, 2023
@unfulvio-godaddy
Copy link
Member

hey @TimBHowe apologies for the terrible delay in replying to you

I see you have closed the PR #492 after receiving feedback

Is this still an issue?

Thank you

@TimBHowe
Copy link
Author

I believe this is still an relevant to add to help payment gateway plugin that use the framework. Unfortunately, I have not had a chance to revisit it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Reporter Feedabck Issues awaiting for OP feedback Payment Gateway Payment gateway code or issues Proposal Proposals and proof-of-concepts
Projects
None yet
Development

No branches or pull requests

2 participants