Skip to content

Commit

Permalink
Merge pull request #102 from gocardless/template-changes
Browse files Browse the repository at this point in the history 
Bump version to 5.15.0
  • Loading branch information
@KarmanLeung
KarmanLeung authored Apr 11, 2023
2 parents 24c5657 + 4458d1d commit 3b11ecd
Show file tree
Hide file tree
Showing 11 changed files with 102 additions and 73 deletions.
4 changes: 2 additions & 2 deletions GoCardless/GoCardless.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<PackageId>GoCardless</PackageId>
<PackageVersion>5.14.0</PackageVersion>
<PackageVersion>5.15.0</PackageVersion>
<Authors>GoCardless Ltd</Authors>
<Description>Client for the GoCardless API - a powerful, simple solution for the collection of recurring bank-to-bank payments</Description>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
Expand All @@ -11,7 +11,7 @@
<Copyright>GoCardless Ltd</Copyright>
<PackageTags>gocardless payments rest api direct debit</PackageTags>
<PackageLicenseUrl>https://github.com/gocardless/gocardless-dotnet/blob/master/LICENSE.txt</PackageLicenseUrl>
<PackageReleaseNotes>https://github.com/gocardless/gocardless-dotnet/releases/tag/v5.14.0</PackageReleaseNotes>
<PackageReleaseNotes>https://github.com/gocardless/gocardless-dotnet/releases/tag/v5.15.0</PackageReleaseNotes>
<TargetFrameworks>netstandard1.6;netstandard2.0;net46</TargetFrameworks>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<GenerateDocumentationFile>true</GenerateDocumentationFile>
Expand Down
4 changes: 2 additions & 2 deletions GoCardless/GoCardlessClient.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@ private HttpRequestMessage BuildHttpRequestMessage<T>(string method, string path
runtimeFrameworkInformation = System.Runtime.InteropServices.RuntimeEnvironment.GetSystemVersion();
#endif

var userAgentInformation = $" gocardless-dotnet/5.14.0 {runtimeFrameworkInformation} {Helpers.CleanupOSDescriptionString(OSRunningOn)}";
var userAgentInformation = $" gocardless-dotnet/5.15.0 {runtimeFrameworkInformation} {Helpers.CleanupOSDescriptionString(OSRunningOn)}";

requestMessage.Headers.Add("User-Agent", userAgentInformation);
requestMessage.Headers.Add("GoCardless-Version", "2015-07-06");
requestMessage.Headers.Add("GoCardless-Client-Version", "5.14.0");
requestMessage.Headers.Add("GoCardless-Client-Version", "5.15.0");
requestMessage.Headers.Add("GoCardless-Client-Library", "gocardless-dotnet");
requestMessage.Headers.Authorization =
new System.Net.Http.Headers.AuthenticationHeaderValue("Bearer", _accessToken);
Expand Down
7 changes: 0 additions & 7 deletions GoCardless/Resources/BillingRequest.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,6 @@ public class BillingRequestActionBankAuthorisation
/// </summary>
[JsonProperty("authorisation_type")]
public string AuthorisationType { get; set; }

/// <summary>
/// Whether an institution is a required field when creating this bank
/// authorisation
/// </summary>
[JsonProperty("requires_institution")]
public bool? RequiresInstitution { get; set; }
}

/// <summary>
Expand Down
8 changes: 5 additions & 3 deletions GoCardless/Resources/BillingRequestFlow.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,11 @@ public class BillingRequestFlow
public bool? ShowRedirectButtons { get; set; }

/// <summary>
/// If true, the payer will be able to see redirect action buttons on
/// Success page. These action buttons will provide a way to redirect
/// payer to the given redirect_uri.
/// If true, the payer will be able to see a redirect action button on
/// the Success page. This action button will provide a way to redirect
/// the payer to the given redirect_uri. This functionality is helpful
/// when merchants do not want payers to be automatically redirected or
/// on Android devices, where automatic redirections are not possible.
/// </summary>
[JsonProperty("show_success_redirect_button")]
public bool? ShowSuccessRedirectButton { get; set; }
Expand Down
7 changes: 0 additions & 7 deletions GoCardless/Resources/Creditor.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,6 @@ namespace GoCardless.Resources
/// </summary>
public class Creditor
{
/// <summary>
/// Boolean value indicating whether the creditor is activated in the
/// product.
/// </summary>
[JsonProperty("activated")]
public bool? Activated { get; set; }

/// <summary>
/// The first line of the creditor's address.
/// </summary>
Expand Down
8 changes: 5 additions & 3 deletions GoCardless/Services/BillingRequestFlowService.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,11 @@ public class BillingRequestFlowPrefilledCustomer
public bool? ShowRedirectButtons { get; set; }

/// <summary>
/// If true, the payer will be able to see redirect action buttons on
/// Success page. These action buttons will provide a way to redirect
/// payer to the given redirect_uri.
/// If true, the payer will be able to see a redirect action button on
/// the Success page. This action button will provide a way to redirect
/// the payer to the given redirect_uri. This functionality is helpful
/// when merchants do not want payers to be automatically redirected or
/// on Android devices, where automatic redirections are not possible.
/// </summary>
[JsonProperty("show_success_redirect_button")]
public bool? ShowSuccessRedirectButton { get; set; }
Expand Down
9 changes: 5 additions & 4 deletions GoCardless/Services/BillingRequestService.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -925,15 +925,16 @@ public class BillingRequestCustomer
public string GivenName { get; set; }

/// <summary>
/// [ISO
/// [ISO
/// 639-1](http://en.wikipedia.org/wiki/List_of_ISO_639-1_codes)
/// code. Used as the language for notification emails sent by
/// GoCardless if your organisation does not send its own (see
/// [compliance requirements](#appendix-compliance-requirements)).
/// Currently only "en", "fr", "de", "pt", "es", "it", "nl", "da",
/// "nb", "sl", "sv" are supported. If this is not provided, the
/// language will be chosen based on the `country_code` (if
/// supplied) or default to "en".
/// "nb", "sl", "sv" are supported. If this is not provided and a
/// customer was linked during billing request creation, the linked
/// customer language will be used. Otherwise, the language is
/// default to "en".
/// </summary>
[JsonProperty("language")]
public string Language { get; set; }
Expand Down
30 changes: 24 additions & 6 deletions GoCardless/Services/CreditorService.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,20 @@ public Task<CreditorResponse> UpdateAsync(string identity, CreditorUpdateRequest
/// <summary>
/// Applies a [scheme identifier](#core-endpoints-scheme-identifiers) to
/// a creditor.
///
/// If the scheme identifier has a `pending` status, it will be applied
/// asynchronously
/// once it becomes `active`.
///
/// If the creditor already has a scheme identifier for the scheme, it
/// will be replaced,
/// and any mandates attached to it transferred asynchronously.
/// For some schemes, the application of the scheme identifier will be
/// performed asynchronously.
/// and any mandates attached to it transferred asynchronously. On Bacs
/// and SEPA, if
/// payments were about to be submitted, they will be delayed. To
/// minimise this delay, we
/// recommend that you apply the new scheme identifier after the daily
/// payment submission
/// time (4 PM Europe/London time).
///
/// </summary>
/// <param name="identity">Unique identifier, beginning with "CR".</param>
Expand Down Expand Up @@ -446,11 +455,20 @@ public class CreditorLinks
/// <summary>
/// Applies a [scheme identifier](#core-endpoints-scheme-identifiers) to a
/// creditor.
///
/// If the scheme identifier has a `pending` status, it will be applied
/// asynchronously
/// once it becomes `active`.
///
/// If the creditor already has a scheme identifier for the scheme, it will
/// be replaced,
/// and any mandates attached to it transferred asynchronously.
/// For some schemes, the application of the scheme identifier will be
/// performed asynchronously.
/// and any mandates attached to it transferred asynchronously. On Bacs and
/// SEPA, if
/// payments were about to be submitted, they will be delayed. To minimise
/// this delay, we
/// recommend that you apply the new scheme identifier after the daily
/// payment submission
/// time (4 PM Europe/London time).
///
/// </summary>
public class CreditorApplySchemeIdentifierRequest
Expand Down
8 changes: 8 additions & 0 deletions GoCardless/Services/InstitutionService.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ public class InstitutionListRequest
public class InstitutionListForBillingRequestRequest
{

/// <summary>
/// [ISO
/// 3166-1](http://en.wikipedia.org/wiki/ISO_3166-1_alpha-2#Officially_assigned_code_elements)
/// alpha-2 code. The country code of the institution.
/// </summary>
[JsonProperty("country_code")]
public string CountryCode { get; set; }

/// <summary>
/// ID(s) of the institution(s) to retrieve. More than one ID can be
/// specified using a comma-separated string.
Expand Down
88 changes: 50 additions & 38 deletions GoCardless/Services/SchemeIdentifierService.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,33 +41,39 @@ public SchemeIdentifierService(GoCardlessClient goCardlessClient)
/// payments are taken
/// using it. The scheme identifier must also have the `status` of
/// active before it can be
/// used. For some schemes e.g. faster_payments this will happen
/// instantly. For other schemes
/// e.g. bacs this can take several days.
/// used. On Bacs, this will take 5 working days. On other schemes, this
/// happens instantly.
///
/// ### Scheme identifier name validations
/// #### Scheme identifier name validations
///
/// Each scheme has different rules for the length and permitted
/// characters in the scheme identifier
/// name field. The rules are:
/// The `name` field of a scheme identifier can contain alphanumeric
/// characters, spaces and
/// special characters.
///
/// | __scheme__ | __maximum length__ | __allowed characters__ |
/// __spaces__ |
/// | :-------------- | :----------------- | :----------------------- |
/// :--------- |
/// | bacs | 18 characters | `a-zA-Z0-9/.&-` |
/// yes |
/// | sepa_core | 70 characters | `a-zA-Z0-9/?:().,+&<>'"` |
/// yes |
/// | ach | 16 characters | `a-zA-Z0-9/?:().,'+-` |
/// yes |
/// | faster_payments | 18 characters | `a-zA-Z0-9/?:().,'+-` |
/// yes |
/// Its maximum length and the special characters it supports depend on
/// the scheme:
///
/// | __scheme__ | __maximum length__ | __special characters
/// allowed__ |
/// | :---------------- | :----------------- |
/// :-------------------------------------------------- |
/// | `bacs` | 18 characters | `/` `.` `&` `-`
/// |
/// | `sepa_core` | 70 characters | `/` `?` `:` `(` `)` `.`
/// `,` `+` `&` `<` `>` `'` `"` |
/// | `ach` | 16 characters | `/` `?` `:` `(` `)` `.`
/// `,` `'` `+` `-` |
/// | `faster_payments` | 18 characters | `/` `?` `:` `(` `)` `.`
/// `,` `'` `+` `-` |
///
/// The validation error that gets returned for an invalid name will
/// contain a suggested name
/// in the metadata that is guaranteed to pass name validations.
///
/// You should ensure that the name you set matches the legal name or
/// the trading name of
/// the creditor, otherwise, there is an increased risk of chargeback.
///
/// </summary>
/// <param name="request">An optional `SchemeIdentifierCreateRequest` representing the body for this create request.</param>
/// <param name="customiseRequestMessage">An optional `RequestSettings` allowing you to configure the request</param>
Expand Down Expand Up @@ -165,33 +171,39 @@ public Task<SchemeIdentifierResponse> GetAsync(string identity, SchemeIdentifier
/// payments are taken
/// using it. The scheme identifier must also have the `status` of active
/// before it can be
/// used. For some schemes e.g. faster_payments this will happen instantly.
/// For other schemes
/// e.g. bacs this can take several days.
/// used. On Bacs, this will take 5 working days. On other schemes, this
/// happens instantly.
///
/// ### Scheme identifier name validations
/// #### Scheme identifier name validations
///
/// Each scheme has different rules for the length and permitted characters
/// in the scheme identifier
/// name field. The rules are:
/// The `name` field of a scheme identifier can contain alphanumeric
/// characters, spaces and
/// special characters.
///
/// | __scheme__ | __maximum length__ | __allowed characters__ |
/// __spaces__ |
/// | :-------------- | :----------------- | :----------------------- |
/// :--------- |
/// | bacs | 18 characters | `a-zA-Z0-9/.&-` | yes
/// |
/// | sepa_core | 70 characters | `a-zA-Z0-9/?:().,+&<>'"` | yes
/// |
/// | ach | 16 characters | `a-zA-Z0-9/?:().,'+-` | yes
/// |
/// | faster_payments | 18 characters | `a-zA-Z0-9/?:().,'+-` | yes
/// |
/// Its maximum length and the special characters it supports depend on the
/// scheme:
///
/// | __scheme__ | __maximum length__ | __special characters
/// allowed__ |
/// | :---------------- | :----------------- |
/// :-------------------------------------------------- |
/// | `bacs` | 18 characters | `/` `.` `&` `-`
/// |
/// | `sepa_core` | 70 characters | `/` `?` `:` `(` `)` `.` `,`
/// `+` `&` `<` `>` `'` `"` |
/// | `ach` | 16 characters | `/` `?` `:` `(` `)` `.` `,`
/// `'` `+` `-` |
/// | `faster_payments` | 18 characters | `/` `?` `:` `(` `)` `.` `,`
/// `'` `+` `-` |
///
/// The validation error that gets returned for an invalid name will contain
/// a suggested name
/// in the metadata that is guaranteed to pass name validations.
///
/// You should ensure that the name you set matches the legal name or the
/// trading name of
/// the creditor, otherwise, there is an increased risk of chargeback.
///
/// </summary>
public class SchemeIdentifierCreateRequest : IHasIdempotencyKey
{
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ For full details of the GoCardless API, see the [API docs](https://developer.goc

To install `GoCardless`, run the following command in the [Package Manager Console](https://docs.microsoft.com/en-us/nuget/tools/package-manager-console)

`Install-Package GoCardless -Version 5.14.0`
`Install-Package GoCardless -Version 5.15.0`


## Usage
Expand Down

0 comments on commit 3b11ecd

Please sign in to comment.