Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename module/namespace #39

Open
trappist opened this issue Oct 14, 2019 · 1 comment
Open

Rename module/namespace #39

trappist opened this issue Oct 14, 2019 · 1 comment

Comments

@trappist
Copy link

I realize this would be a disruptive change, but I have to maintain my own fork with the Business module renamed to BusinessDay because my application has a class named Business. Probably not a common problem, but I think a best practice would be to establish a namespace that's more specific and descriptive, and as such less likely to conflict with other code. Happy to submit a PR if there's any interest in pursuing this.

@grillermo
Copy link

grillermo commented Mar 3, 2021

A more common problem than you think, a pretty common word.
A fork up to date with the module rename to BusinessDay here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants