Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add define command to define common words and terms #6

Open
ScottMansfield opened this issue Jun 3, 2020 · 2 comments
Open

Add define command to define common words and terms #6

ScottMansfield opened this issue Jun 3, 2020 · 2 comments

Comments

@ScottMansfield
Copy link

Add a simple command to define a word. I was thinking this should be an API somewhere we can hit to get a reasonable answer but realistically it will have to be a curated list.

The terms to be defined would probably just be Go terms, but there could be a fallback to a dictionary API for ESL people. It's probably over-complicating though.

Previous discussion here: gobridge/gopher#33
@theckman
Copy link
Contributor

theckman commented Jun 4, 2020

@ScottMansfield are you aware of anything that exists like this today, even in a text form?

theckman added a commit that referenced this issue Jun 5, 2020
@theckman
Initial commit of built-in glossary of terms, using define command
f03c976 
Well, singular. Starting out with one term for the initial pass, and will
crowd-source more of them.

Updates #6
theckman added a commit that referenced this issue Jun 5, 2020
@theckman
Initial commit of built-in glossary of terms, using define command
f4df3ee 
Well, singular. Starting out with one term for the initial pass, and will
crowd-source more of them.

This also adds another method to the Responder, `RespondTo`, for mentioning the
user who triggered the command in the response.

Updates #6
@theckman theckman mentioned this issue Jun 5, 2020
Merged
@theckman
Copy link
Contributor

theckman commented Jun 5, 2020

This is basically finished, but am thinking it makes sense to get more definitions in before closing this:

https://github.com/gobridge/gopherbot/blob/master/glossary/terms.go#L5

Mind contributing some?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScottMansfield @theckman