Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal Luck includes pending validators in the calculation #221

Open
p4fg opened this issue May 8, 2023 · 5 comments
Open

Proposal Luck includes pending validators in the calculation #221

p4fg opened this issue May 8, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@p4fg
Copy link

p4fg commented May 8, 2023

Describe the bug
The tab "Blocks" has a field "Proposal Luck" that includes non-activated/pending validators in the calculation of how many blocks is expected on average.

To Reproduce

  1. Create a new profile
  2. Add one active validator
  3. Add ten pending validators
  4. Visit the Blocks-tab and observe the proposal luck
  5. Click / press the questionmark and view the data saying "Your 11 validators are expected to produce XX blocks per month".

Expected behavior
Only activated validators should be included in the calculation. Pending validators cannot produce any blocks.

@p4fg p4fg added the bug Something isn't working label May 8, 2023
@manuelsc
Copy link
Collaborator

manuelsc commented May 8, 2023

Thanks for your bug report, I'm adding it to our todos

@b0a7
Copy link

b0a7 commented Sep 29, 2023

it also includes exited validators

@Jircs1
Copy link

Jircs1 commented Mar 9, 2024

😁

@jircs
Copy link

jircs commented Mar 26, 2024

👍

1 similar comment
@Motiff2
Copy link

Motiff2 commented Aug 30, 2024

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants
@p4fg @manuelsc @jircs @Jircs1 @b0a7 @Motiff2 and others