Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: restarted pull_request labeled builds missing steps #993

Open
plyr4 opened this issue Aug 8, 2024 · 3 comments
Open

server: restarted pull_request labeled builds missing steps #993

plyr4 opened this issue Aug 8, 2024 · 3 comments
Labels
bug Indicates a bug

Comments

@plyr4
Copy link
Contributor

plyr4 commented Aug 8, 2024

see title, use the following yaml, trigger a build, restart it. build will be missing the labeled step

  - name: pull-labeled-with-bug
    image: golang
    ruleset:
      event: 'pull_request:labeled'
      label: [ 'bug' ]
    commands:
      - echo "pull request labeled"

  - name: run-always
    image: golang
    commands:
      - echo "run always"
@plyr4 plyr4 added the bug Indicates a bug label Aug 8, 2024
@ecrupper
Copy link
Contributor

ecrupper commented Aug 9, 2024

This extends to comment steps with additional comment specification, e.g.

  - name: comment-with-bug
    image: golang
    ruleset:
      event: comment
      comment: "test suite"
    commands:
      - echo "running comment-driven test suite"

  - name: run-always
    image: golang
    commands:
      - echo "run always"

@wass3r
Copy link
Collaborator

wass3r commented Aug 10, 2024

Either we implement saving the state or document and prevent ability to restart these types of events.

@wass3r
Copy link
Collaborator

wass3r commented Aug 14, 2024

re Easton's comment, we have this out there #453 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug
Projects
None yet
Development

No branches or pull requests

3 participants