Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init step logs spills into subsequent step #1013

Open
wass3rw3rk opened this issue Oct 8, 2024 · 1 comment
Open

init step logs spills into subsequent step #1013

wass3rw3rk opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
area/worker Indicates a change to the worker bug Indicates a bug

Comments

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Oct 8, 2024

Description

In certain scenarios it is possible for the init step logs to be prepended to a subsequent step's logs erroneously. Using the pipeline below, you will see that the clone step logs will start out with the init step logs' content.

Value

Log should be properly captured in all scenarios.

Useful Information

pipeline to reproduce:

.vela.yml

version: "1"

steps:
  - name: echo
    image: alpine:latest
    commands:
      - echo hello

secrets:
  - origin:
      name: vault one
      image: alpine:latest
      parameters:
        log.level: trace
  - origin:
      name: vault two
      image: alpine:latest
      parameters:
        log.level: trace

Secrets plugin is faked here for ease of testing. This will reproduce the issue 100% of the time in my testing. Check clone step log to see the issue.

A scenario we have seen this in is when folks use multiple templates and multiple are using the secret plugin.

  1. What is the output of vela --version?

<= v0.25.x

  1. What operating system is being used?
  1. Any other important details?
@wass3rw3rk wass3rw3rk added bug Indicates a bug area/worker Indicates a change to the worker labels Oct 8, 2024
@wass3rw3rk wass3rw3rk self-assigned this Oct 8, 2024
@wass3rw3rk wass3rw3rk changed the title Log from init step spills into subsequent step Init step logs spills into subsequent step Oct 8, 2024
@wass3r wass3r changed the title Init step logs spills into subsequent step init step logs spills into subsequent step Oct 9, 2024
@wass3r
Copy link
Collaborator

wass3r commented Nov 23, 2024

this is a dupe of #985, but inclined to keep this one open due to additional info - otherwise we can move the info to the other issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/worker Indicates a change to the worker bug Indicates a bug
Projects
None yet
Development

No branches or pull requests

2 participants