New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When tags are passed to RecordSpan no tags are recorded. #13

Open

tparker00 opened this issue Aug 20, 2024 · 0 comments · May be fixed by #14

tparker00 commented Aug 20, 2024

When sending tags in they are ignored and only the default quantile tags are added.

Looking at the function the tags value is never used

telemetry/telemetry.go

Lines 175 to 177 in 4591c19

    
           func (n *Scope) RecordSpan(measurement string, tags map[string]string) tally.Stopwatch { 
        
           	return n.scope.Timer(measurement + "_span").Start() 
        
           }

tparker00 linked a pull request

that will close this issue

Add tag support for RecordSpan #14

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment