Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Content ContentTypeForm #6

Open
yohei1126 opened this issue Nov 3, 2017 · 7 comments
Open

Support Content ContentTypeForm #6

yohei1126 opened this issue Nov 3, 2017 · 7 comments

Comments

@yohei1126
Copy link

yohei1126 commented Nov 3, 2017 •
edited
Loading

decorder does not support application/x-www-form-urlencoded yet

render/decoder.go

Line 28 in 7bbdb19

// case ContentTypeForm: // TODO

@VojtechVitek
Copy link
Contributor

#4 ?

@VojtechVitek
Copy link
Contributor

Mind testing the PR please?

@yohei1126
Copy link
Author

thanks!

@VojtechVitek
Copy link
Contributor

Would be nice to close this after we merge #4. Any help with testing it would be appreciated.

@VojtechVitek VojtechVitek reopened this Nov 3, 2017
@yohei1126
Copy link
Author

no test code for #4?

@syntaqx
Copy link
Contributor

syntaqx commented Nov 17, 2017

@yohei1126 There's no test code anywhere in this codebase. I didn't want to introduce my testing preferences onto the code, as I'd use Testify by default.

@syntaqx
Copy link
Contributor

syntaqx commented Nov 17, 2017

@VojtechVitek If you're concerned about testing on it, if it makes you feel any better, that code has been running in production for quite some time and hasn't had any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@VojtechVitek @yohei1126 @syntaqx