Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error messages in TestDefault #28

Open
ablankz opened this issue May 3, 2024 · 0 comments
Open

Fixed error messages in TestDefault #28

ablankz opened this issue May 3, 2024 · 0 comments

Comments

@ablankz
Copy link
Contributor

ablankz commented May 3, 2024

A partial code of cors_test.go is shown below.

if s.allowedHeaders == nil {
    t.Error("c.allowedHeaders should be nil when Default")
}
if s.allowedMethods == nil {
    t.Error("c.allowedMethods should be nil when Default")
}

We believe the following message is appropriate for this.

if s.allowedHeaders == nil {
    t.Error("c.allowedHeaders must not be nil when Default")
}
if s.allowedMethods == nil {
    t.Error("c.allowedMethods must not nil when Default")
}
ablankz added a commit to ablankz/cors that referenced this issue May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant