Replace walletconnet library #832
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrypalacios
commented
Nov 29, 2021
| @@ -63,7 +63,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@amcharts/amcharts4": "^4.10.13", | |||
| "@anxolin/walletconnect-connector": "6.1.9", | |||
There was a problem hiding this comment.
I think you don't need to use my library any more :)
u are welcome to use it, but this was a temporal fix while they would accept my PR
henrypalacios
commented
Nov 29, 2021
| import { WalletLinkConnector } from '@web3-react/walletlink-connector' | ||
|
|
||
| import { NETWORK_URL_MAINNET, PORTIS_ID } from '../constants/config' | ||
| import { ChainId, NETWORK_CONFIGS } from './../utils/index' | ||
|
|
||
| const POLLING_INTERVAL = 10000 |
There was a problem hiding this comment.
Polling has now been disabled as mentioned here
henrypalacios
force-pushed
the
671-wcmodal-appears-after-discn
branch
from
e7edda6 to
1c16ba3
Compare
|
josojo
approved these changes
Dec 1, 2021
elena-zh
suggested changes
Dec 1, 2021
There was a problem hiding this comment.
Hi @henrypalacios , great that you have added these changes!
But I would vote not for deploying them now due to I have found several issues:
-
Wallet is unknown when connected to a WC wallet
-
I can't connect to TrustWallet, imToken wallet: I get the connected message in the wallet, but no active connection log in the app settings. Eternal loader is displayed in the GA app
-
WC connection is closed when
- the page reload the app
- then open any auction details page --> the wallet is disconnected inside the connected app, but connection is still active in the GA app
See the video: it is recorded for the Gnosis safe wallet, but the same behavior is applicable to the TockenPocket, DeFi, MM wallet.
As the result, I can't place an order:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #671
Proposal:
Update dependencias related to
walletconnectand adjust the code that resolve this conflict.Credit to @nenadV91 who referenced.