-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn popup updated #782
base: develop
Are you sure you want to change the base?
warn popup updated #782
Conversation
|
|
@elena-zh please check |
updated |
Hi @maria-vslvn , |
@elena-zh please check |
@maria-vslvn , great job! The only thing I'd like to notice, that token names on the modal are WETH and wxDAI. However, I'm not sure whether it is an issue.. @josojo , could you please take a look and clarify whether we should show ETH/xDAI everywhere on the modal, or leave it as it is? Also, I did not have a possibility to test changes in the Mainnet.. Alex, could you please check these changes there? Thanks |
Yes the behaviour would be correct with ETH/xdai instead of WETH/wxdai. @maria-vslvn you can just use the function:
to display it correctly |
@elena-zh please check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIce. thanks. Looks good now
@maria-vslvn could you please tackle the issue from elena? then we can merge it and complete the task |
@elena-zh please check |
@maria-vslvn , still there is no additional message =( |
Closes #672
Cancel popup updated according to new mockups