Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn popup updated #782

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

warn popup updated #782

wants to merge 10 commits into from

Conversation

maria-vslvn
Copy link
Contributor

@maria-vslvn maria-vslvn commented Jul 13, 2021

Closes #672
Cancel popup updated according to new mockups

@github-actions
Copy link

  • 🔭 IDO UI: Easy IDO auction

@elena-zh
Copy link

@maria-vslvn ,

  1. additional message on the pop-up should not be displayed when bidding tokens are not ETH (for Rinkeby and Mainnet networks) and xDAI (for xDAI network)
    should not be displayed

  2. Token pair (DAI per GNO) should not me mocked on the pop-up and should consider < selling token > and < buying token > values
    token values

  3. Label should not contain 'Min (max)' in 1 line. Min should be displayed when label is 'Min bidding price' in the price field. Max should be displayed when label is 'Max bidding price' in the price field. See my comment here
    max

  4. Warning message should not be mocked as well. It should take into consideration bidding token value:

  • If you Cancel an order in xDAI, you will receive back WXDAI tokens in xDAI. - for xDAI network
  • If you Cancel an order in ETH, you will receive back WETH tokens in Rinkeby.- for Rinkeby network
  • If you Cancel an order in ETH, you will receive back WETH tokens in Mainnet.- for Mainnet network

@maria-vslvn
Copy link
Contributor Author

@elena-zh please check

@elena-zh
Copy link

@maria-vslvn ,

  1. The 2nd warning message on the cancellation pop-up should be always displayed in all auctions:
    2nd message should present everywhere

  2. Besides, neither the 1st nor the 2nd warning message are not displayed on the cancellation pop-up when cancel orders with ETH/XDAI bidding token

  3. Min 'ETH' instead of 'WETH' (and xDAI instead of WXDAI) should be displayed on the pop-up message
    no at all + ETH

  4. Token's pair should be reverted as well (besides changing min/max label):
    token pair min

  5. Token icons should be bigger and should not be shifted towards numbers (see as an example 'Place order' pop-up)
    token icons

@maria-vslvn
Copy link
Contributor Author

updated

@elena-zh
Copy link

Hi @maria-vslvn ,
changes look much better, however, these issues are still not fixed:

  1. When invert price, not only token's pair should be changed, price itself should be changed as well
    inverted

  2. Still, i do not see an additional warning neither for ETH token in Rinkeby and Mainnet, nor for XDAI token in the XDAI
    weth-eth
    xdai

@maria-vslvn
Copy link
Contributor Author

@elena-zh please check

@elena-zh
Copy link

@maria-vslvn , great job!

The only thing I'd like to notice, that token names on the modal are WETH and wxDAI.

However, I'm not sure whether it is an issue.. @josojo , could you please take a look and clarify whether we should show ETH/xDAI everywhere on the modal, or leave it as it is?
eth-weth
xdai

Also, I did not have a possibility to test changes in the Mainnet.. Alex, could you please check these changes there?

Thanks

@josojo
Copy link
Contributor

josojo commented Jul 29, 2021

Yes the behaviour would be correct with ETH/xdai instead of WETH/wxdai.

@maria-vslvn you can just use the function:

getTokenDisplay(biddingToken, chainId) or getTokenDisplay(auctioningToken, chainId)

to display it correctly

@maria-vslvn
Copy link
Contributor Author

@elena-zh please check

Copy link
Contributor

@josojo josojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIce. thanks. Looks good now

@elena-zh
Copy link

Additional warning now is missing when cancel an order in ETH:
image

@josojo
Copy link
Contributor

josojo commented Aug 9, 2021

@maria-vslvn could you please tackle the issue from elena? then we can merge it and complete the task

@maria-vslvn
Copy link
Contributor Author

@elena-zh please check

@elena-zh
Copy link

@maria-vslvn , still there is no additional message =(
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn a user about receiving WETH/WXDAI tokens after cancellation
3 participants