Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Walletconnect modal appears again after a wallet disconnection #671

Open
elena-zh opened this issue Jun 10, 2021 · 3 comments · May be fixed by #832
Open

Walletconnect modal appears again after a wallet disconnection #671

elena-zh opened this issue Jun 10, 2021 · 3 comments · May be fixed by #832
Assignees
@hpmaxi
Labels
bug Something isn't working medium priority QA issues created by QA

Comments

@elena-zh
Copy link

elena-zh commented Jun 10, 2021 •
edited
Loading

Related to #650, #562

The issue is not 100% reproducible, but often happens.
Walletconnect modal appears after disconnection of a wallet. And it is not closed when connect a wallet using it once again.
https://drive.google.com/file/d/1POb25DYAo20pKUplDAEVJmkVWA8uuY82/view

Expected: walletconnect modal is not displayed after a wallet disconnection.
@elena-zh elena-zh added bug Something isn't working medium priority QA issues created by QA labels Jun 10, 2021
@elena-zh elena-zh mentioned this issue Jun 10, 2021
Merged
@elena-zh
Copy link
Author

fixed in #650

@henrypalacios
Copy link
Contributor

@elena-zh, has appeared to me again. I had already encountered false positives.

@elena-zh
Copy link
Author

Hey @henrypalacios , thank you! Then, I will reopen the issue.
Thanks!

@hpmaxi hpmaxi self-assigned this Jun 16, 2021
@henrypalacios henrypalacios linked a pull request Nov 29, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hpmaxi hpmaxi

Labels
bug Something isn't working medium priority QA issues created by QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace walletconnet library gnosis/ido-ux
3 participants
@hpmaxi @henrypalacios @elena-zh