Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from updated version (V. 0.4) #12

Closed
10 of 12 tasks
hpmaxi opened this issue Mar 22, 2021 · 3 comments
Closed
10 of 12 tasks

Feedback from updated version (V. 0.4) #12

hpmaxi opened this issue Mar 22, 2021 · 3 comments
Assignees

Comments

@hpmaxi
Copy link
Contributor

hpmaxi commented Mar 22, 2021

From Elena's feedback

  • Add validation to amount fields, only valid amounts should pass validation example
  • Avoid clearing out fields if the tx is not sent. Ex. Canceled submit modal, some error inside initiateAuction
  • Show a modal if the tx is successful with the auctionId + clear out the fields on the form after successful transaction
  • Divider between 4 and 5 field must be removed
  • Dates fields are narrower.
  • Change in tooltipText and labels buytAmount to amount to buy, allowListManager as List Manager, etc.
  • Calendar is transparent, make it solid.
  • Invalid ERC20 for 0x4dbcdf9b62e891a7cec5a2568c3f4faf9e8abe2b is incorrect.
  • No validations when dates are empty or cancelDate > closingDate. Keep 'Build transaction' disabled when date = today + time in the past. Errors could being cleared out by the build button.
  • Cancel TX should not reset form.
  • gasPrice/gasLimit is not set automatically?
  • ThirdParty errors in console.
@elena-zh
Copy link

Hi Maxi!
I think, that the next cases are already fixed:

  • Invalid ERC20 for 0x4dbcdf9b62e891a7cec5a2568c3f4faf9e8abe2b is incorrect.
  • Cancel TX should not reset form.

@hpmaxi
Copy link
Contributor Author

hpmaxi commented Mar 25, 2021

@elena-zh
Third Party errors seems related to safe-react-app-sdk package. I can't solve it for the moment, and about the modal with the auctionId there is the issue #29 . Maybe we can close this?

@elena-zh
Copy link

Hi @hpmaxi ,
yes, we can close this issue, as for unfixed cases separate issues are created.

Thanks

@hpmaxi hpmaxi closed this as completed Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants