Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sharing is Caring] Move Discriminated Union Type for allEvents Upstream #706

Open
nlordell opened this issue Apr 30, 2020 · 0 comments
Open

[Sharing is Caring] Move Discriminated Union Type for allEvents Upstream #706

nlordell opened this issue Apr 30, 2020 · 0 comments
Labels
cleanup

Comments

@nlordell
Copy link
Contributor

#705 includes some TS type arithmetic to create a discriminated union for the allEvents event type on the event property so that you get more type safety when using those events.

This is something that we can potentially move upstream to TypeChain so the code gets generated this way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nlordell