-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.20/General maintenance #22
base: master
Are you sure you want to change the base?
Conversation
Gradle 8.1.+ is needed for Loom 1.2, which is recommended for 1.20 development.
Updated Loom to 1.2.+, updated Minecraft to 1.20-rc1, updated Yarn to 1.20-rc1+build.2, and the Fabric loader to 0.14.21
Fixes the "Loom is applying dependency data manually to publications instead of using a software component (from(components["java"]))" message
JCentral is not accepting new versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI needs to be updated.
this is based on what the fabric example mod do
stuff include adding issues link and strenghtening mc version requirement
i have made changes to this pr on my fork and wanted to pr them to this pr, but i can't seem to get it to pr on the pr this is the pr but with my changes : https://github.com/Julienraptor01/chat-up/tree/pr/22-edited the changes are :
|
@Julienraptor01 If you want I can close this PR and you open your own with your repo, or I can rebase your commits onto my repo and keep this PR. |
yeah @JetbladeDevsStuff you can rebase my commits onto your fork, it's fine |
actually, wait a bit, i've just seen the notification for loom 1.3 so we might as well update to it too |
apparently it's out and should be better, doesn't seem to cause any issue
i've done the loom 1.3 update and it doesn't cause any issues, you can now rebase my commits 👍 |
Ok, your changes are now merged into my repository. Thanks for doing the Gradle stuff, as I'm not that great at Gradle. |
Updates the mod to build with Minecraft 1.20 and updates dependencies (Loom, Yarn, Loader) to the versions recommended by Fabric. Also removes JCentral publishing, as it no longer accepts new versions. Updated actual mod version so that the new version number appears in game and in MultiMC (fixes #21).
I have tested the mod.
P.S. You should look into creating a page on Modrinth and implementing Minotaur support.