Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.20/General maintenance #22

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JetbladeDevsStuff
Copy link

@JetbladeDevsStuff JetbladeDevsStuff commented Jun 5, 2023

Updates the mod to build with Minecraft 1.20 and updates dependencies (Loom, Yarn, Loader) to the versions recommended by Fabric. Also removes JCentral publishing, as it no longer accepts new versions. Updated actual mod version so that the new version number appears in game and in MultiMC (fixes #21).

I have tested the mod.

P.S. You should look into creating a page on Modrinth and implementing Minotaur support.

Gradle 8.1.+ is needed for Loom 1.2, which is recommended for 1.20
development.
Updated Loom to 1.2.+, updated Minecraft to 1.20-rc1, updated Yarn
to 1.20-rc1+build.2, and the Fabric loader to 0.14.21
Fixes the "Loom is applying dependency data manually to publications
instead of using a software component (from(components["java"]))"
message
JCentral is not accepting new versions.
Copy link

@Kichura Kichura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to be updated.

.github/workflows/devbuild.yml Outdated Show resolved Hide resolved
.github/workflows/build-on-pr.yml Show resolved Hide resolved
Switch to temurin Java, and upgrade all actions to v3
this is based on what the fabric example mod do
stuff include adding issues link and strenghtening mc version requirement
@Julienraptor01
Copy link

i have made changes to this pr on my fork and wanted to pr them to this pr, but i can't seem to get it to pr on the pr

this is the pr but with my changes : https://github.com/Julienraptor01/chat-up/tree/pr/22-edited

the changes are :

  • gradle 8.2 update
  • minecraft 1.20.1 update since it's now out
  • modified fabric.json and build.gradle to automatically set the right version into fabric.json for the sake of easiness
  • gradle.properties change to use org.gradle.parallel

@JetbladeDevsStuff
Copy link
Author

@Julienraptor01 If you want I can close this PR and you open your own with your repo, or I can rebase your commits onto my repo and keep this PR.

@Julienraptor01
Copy link

Julienraptor01 commented Jul 5, 2023

@Julienraptor01 If you want I can close this PR and you open your own with your repo, or I can rebase your commits onto my repo and keep this PR.

yeah @JetbladeDevsStuff you can rebase my commits onto your fork, it's fine

@Julienraptor01
Copy link

actually, wait a bit, i've just seen the notification for loom 1.3 so we might as well update to it too

apparently it's out and should be better, doesn't seem to cause any issue
@Julienraptor01
Copy link

i've done the loom 1.3 update and it doesn't cause any issues, you can now rebase my commits 👍

@JetbladeDevsStuff
Copy link
Author

Ok, your changes are now merged into my repository. Thanks for doing the Gradle stuff, as I'm not that great at Gradle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect version number in fabric.mod.json
3 participants