Skip to content
This repository has been archived by the owner on Jul 7, 2020. It is now read-only.

Update README.md #492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,8 @@ $ vagrant ssh master
[vagrant@master]$ mv topology.json.sample topology.json
```

*If not running in the provided vagrant, make sure to edit the topology.json node, zone, device names to match you're kubernetes cluster.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fix the contraction "you're" (you are) to the possessive "your".
  • I would also expand "vagrant" to "default Vagrant environment" because its actually fairly easy to tweak the vagrant setup (I do).
  • Kubernetes should be capitalized, I think.
  • Your commit message should probably say something like "Update README.md to remind users to match topology.json to vagrant" or something like that


The following commands are meant to be run with administrative privileges
(e.g. `sudo su` beforehand).

Expand Down