This repository has been archived by the owner on Jul 7, 2020. It is now read-only.
Update README.md #492
Open
Update README.md #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
phlogistonjohn
suggested changes
Jun 27, 2018
| @@ -78,6 +78,8 @@ $ vagrant ssh master | |||
| [vagrant@master]$ mv topology.json.sample topology.json | |||
| ``` | |||
|
|
|||
| *If not running in the provided vagrant, make sure to edit the topology.json node, zone, device names to match you're kubernetes cluster.* | |||
There was a problem hiding this comment.
- Please fix the contraction "you're" (you are) to the possessive "your".
- I would also expand "vagrant" to "default Vagrant environment" because its actually fairly easy to tweak the vagrant setup (I do).
- Kubernetes should be capitalized, I think.
- Your commit message should probably say something like "Update README.md to remind users to match topology.json to vagrant" or something like that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is