Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break apart lib.rs #80

Open
Marwes opened this issue Sep 21, 2018 · 3 comments
Open

Break apart lib.rs #80

Marwes opened this issue Sep 21, 2018 · 3 comments

Comments

@Marwes
Copy link
Member

Marwes commented Sep 21, 2018

lib.rs is about to be over 3k lines with #79 so we should really break it up in a few submodules. Might make sense to break it up roughly in the sections in https://microsoft.github.io/language-server-protocol/specification maybe?

@Marwes
Copy link
Member Author

Marwes commented Sep 21, 2018

Also, do we want re-export all the types currently in lib.rs after they are moved?

@matklad
Copy link
Contributor

matklad commented Nov 5, 2018

FWIW, as a user of langaugeserver_types, I slightly prefer everything to be in one single file: it's easier to search for things when browsing source.

@kjeremy
Copy link
Contributor

kjeremy commented Mar 2, 2020

I think this is worth revisiting. I've struggled to catch everything when adding (and specifically modifying) types for new protocol versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants