Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diffraction normalization should be S(k=0) = N #789

Closed
bdice opened this issue Jun 2, 2021 · 0 comments · Fixed by #835
Closed

Diffraction normalization should be S(k=0) = N #789

bdice opened this issue Jun 2, 2021 · 0 comments · Fixed by #835

Comments

@bdice
Copy link
Member

bdice commented Jun 2, 2021

We should change the normalization criteria of the DiffractionPattern such that S(k=0) = N. Currently it is S(k=0) = 1. The typical formulation in physics (see Wikipedia) gives a result of N but we changed it to 1 so it's easier to plot. However, we can just adapt the plotting code to re-scale as needed, and keep the normal physics convention.

Originally posted by @bdice in #777 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant