Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions "publish" job should not run on PR builds or from repo forks #534

Open
sirosen opened this issue Jun 24, 2021 · 0 comments
Open
Labels
bug Something isn't working

Comments

@sirosen
Copy link
Member

sirosen commented Jun 24, 2021

Describe the bug

I've noticed failures of the "publish" job (and therefore apparently "failing" CI) on my fork and on my PR builds.
These will always fail, and it would be better to skip the job in these contexts to get clearer feedback.

I believe that the job should be guarded with an if that looks to make sure it's running on funcx-faas/funcX@main.
The GitHub env vars and workflow expression language should make this possible.

To Reproduce

  1. Fork the repo
  2. Create a new branch off of main with no changes
  3. Push to your fork
  4. GitHub will email you a build failure

Expected behavior

Since the new branch is taken off of main, you would expect a passing build.

@sirosen sirosen added the bug Something isn't working label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant