Added logic to clean up executor interchange log #513
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogs when there is no outstanding task
Codecov Report
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
- Coverage 38.52% 36.14% -2.39%
==========================================
Files 27 27
Lines 2855 3511 +656
==========================================
+ Hits 1100 1269 +169
- Misses 1755 2242 +487
Continue to review full report at Codecov.
|
ZhuozhaoLi
reviewed
Jun 14, 2021
| @@ -47,7 +47,13 @@ def strategize(self, *args, **kwargs): | |||
|
|
|||
| def _strategize(self, *args, **kwargs): | |||
| task_breakdown = self.interchange.get_outstanding_breakdown() | |||
| logger.info(f"Task breakdown {task_breakdown}") | |||
| num_tasks = 0 | |||
There was a problem hiding this comment.
no need to sum here. We can log if there is any non-zero entry, which is a bit faster.
|
Although I don't know what that "breakdown" object is, this seems to me like an unnecessary change which potentially loses information. @yadudoc, I'd like to close (not merge) this to cleanup our outstanding PRs. Do you agree? |
|
@sirosen I agree. Sorry, I did not see your comment here sooner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in Issue #511, for endpoint, there is a log line being generated every second for executor interchange, even there is no outstanding task. It is good for debugging, but might not be the case for production running. This PR changes the log level from
infotodebug, when there is no outstanding task.