Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning if flow is not published #3142

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

akanshaaa19
Copy link
Member

target issue is #3115

@akanshaaa19 akanshaaa19 linked an issue Nov 25, 2024 that may be closed by this pull request
@akanshaaa19 akanshaaa19 self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 05:28 Inactive
Copy link

cypress bot commented Nov 25, 2024

Glific    Run #5425

Run Properties:  status check failed Failed #5425  •  git commit a32fa97ecf ℹ️: Merge 2e26163f6f2df1ece4ad99a10684e7e7c2202d01 into 5a3b2b6bacdd1b02f97ed916a770...
Project Glific
Branch Review enhancement/flow-warning
Run status status check failed Failed #5425
Run duration 26m 11s
Commit git commit a32fa97ecf ℹ️: Merge 2e26163f6f2df1ece4ad99a10684e7e7c2202d01 into 5a3b2b6bacdd1b02f97ed916a770...
Committer Akansha Sakhre
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 168
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/flow/FlowEditor.spec.ts • 1 failed test

View Output

Test Artifacts
Flow > should configure Flow Test Replay Screenshots

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 07:15 Inactive
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.79%. Comparing base (5a3b2b6) to head (2e26163).

Files with missing lines Patch % Lines
src/components/floweditor/FlowEditor.tsx 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
+ Coverage   81.74%   81.79%   +0.04%     
==========================================
  Files         329      329              
  Lines       10558    10569      +11     
  Branches     2233     2237       +4     
==========================================
+ Hits         8631     8645      +14     
+ Misses       1314     1309       -5     
- Partials      613      615       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 07:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 23:11 Inactive
Copy link
Contributor

@kurund kurund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akanshaaa19

Tests are failing, can you please check? I have done another test run.

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 23:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning if flow not published
2 participants