Refactoring: Separating HSM and Speed sends #3063
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-3063--glific-frontend.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3063 +/- ##
==========================================
+ Coverage 80.97% 81.17% +0.20%
==========================================
Files 323 319 -4
Lines 10351 10340 -11
Branches 2198 2174 -24
==========================================
+ Hits 8382 8394 +12
+ Misses 1340 1316 -24
- Partials 629 630 +1 ☔ View full report in Codecov by Sentry. |
Glific
|
||||||||||||||||||||||||
| Project |
Glific
|
| Run status |
|
| Run duration | 25m 27s |
| Commit |
|
| Committer | Akansha Sakhre |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
172
|
kurund
requested changes
Oct 11, 2024
| @@ -22,7 +22,7 @@ import { GroupCollectionList } from 'containers/WaGroups/GroupCollections/GroupC | |||
| const Chat = lazy(() => import('containers/Chat/Chat')); | |||
| const Layout = lazy(() => import('components/UI/Layout/Layout')); | |||
| const SpeedSendList = lazy(() => import('containers/Template/List/SpeedSendList/SpeedSendList')); | |||
| const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSend/SpeedSend')); | |||
| const SpeedSend = lazy(() => import('containers/Template/Form/SpeedSends/SpeedSends')); | |||
There was a problem hiding this comment.
If possible let's avoid fodder and file renaming.
…tend into templates-refactoring
kurund
requested changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.