Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post event when popup is opened #36

Merged
merged 1 commit into from
May 3, 2024
Merged

Post event when popup is opened #36

merged 1 commit into from
May 3, 2024

Conversation

jdgarcia
Copy link
Contributor

@jdgarcia jdgarcia commented May 3, 2024

No description provided.

@jdgarcia jdgarcia requested a review from miggy-e May 3, 2024 00:28
Copy link
Collaborator

@miggy-e miggy-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event worked for me, have a comment about adding more browser data.

Comment on lines +200 to +194
body: JSON.stringify({
source: 'browser_extension',
event: event,
data: data,
}),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the browser/ browser version here as well?

@jdgarcia jdgarcia force-pushed the popup-opened-event-log branch from 0a645b6 to cc1e01b Compare May 3, 2024 21:13
@jdgarcia jdgarcia merged commit ff2ec61 into main May 3, 2024
1 check passed
@jdgarcia jdgarcia deleted the popup-opened-event-log branch May 3, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants