GKCS-5303 Allow the browser extension to connect to On-premise GitHub environments #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdgarcia
requested changes
Feb 28, 2024
|
FYI I split the permission handling portion of this into #22 |
gitkrakel
force-pushed
the
GKCS-5303-allow-the-browser-extension-to
branch
6 times, most recently
from
9a72116 to
89c5618
Compare
gitkrakel
force-pushed
the
GKCS-5303-allow-the-browser-extension-to
branch
from
89c5618 to
219b28a
Compare
jdgarcia
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitkraken.atlassian.net/browse/GKCS-5303
Tested with https://ghe.ci.gitkraken.com (running Enterprise v3.11.2).
There are buttons on commit comparison, individual commits, and repo landing pages. (i.e.
< > Codetab of a repo).However for PRs, I noticed there's no
< > Codebutton, so I didn't add any buttons on PR pages (note: this might be because our instance is behaving weirdly right now: https://gitkraken-hq.slack.com/archives/C05BYV78VQB/p1709170626154339)