Style and icon updates #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miggy-e
reviewed
Jan 25, 2024
| const main = async () => { | ||
| // Update the extension icon based on whether the user is logged in. | ||
| const user = await fetchUser(); | ||
| void updateExtensionIcon(Boolean(user)); |
There was a problem hiding this comment.
there's this open issue, would it be hard to include it in this PR? https://gitkraken.atlassian.net/browse/GKCS-4724 if not, could you also make a change for it? it doesn't seem too differnt from what's happening here, we just need to determine if the browser is in dark or light mode
There was a problem hiding this comment.
@miggy-e I don't have separate light mode and dark mode icons, so I'll save it for when I do. I'll ask Nastya to prepare them
miggy-e
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitkraken.atlassian.net/browse/GKCS-4908
The icon updates to a green icon if the user is signed in. We check if the user is signed at two instances:
This means the icon won't update immediately when the user signs in or signs out. Doing so would probably require either message passing or maybe polling. That seems like a bit bunch, but we can add that later if product says they really want it.