Extension popup with Sign In / Sign Out #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, UI icons are also missing from this PR. I need to figure out how to add those. |
|
Oh, this also only works for prod. Not sure how we'd setup support for other environments yet. |
miggy-e
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://gitkraken.atlassian.net/browse/GKCS-4908
cookiesas a required permissiongitkraken.devas a site this extension can access info aboutNote: the referenced Figma shows more UI elements but this PR this PR / Jira card focuses just on auth
As the popup UI becomes more complicated, it might be worth considering utilizing a framework (such as React) and webpacking it. Not sure if that would be overkill or not for just a popup though.