Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid resetting scroll position after clicking a node in the graph viewer #3833

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Nov 20, 2024

When clicking a node in the graph viewer, it would reset the scroll position, similar to what happens when clicking a link with href="#" (such as this link). This PR fixes that.

reset-scroll

@asgerf asgerf marked this pull request as ready for review November 21, 2024 07:48
@asgerf asgerf requested a review from a team as a code owner November 21, 2024 07:48
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I haven't tried this out, but it looks reasonable.

@asgerf asgerf merged commit dba6718 into github:main Nov 22, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants