Fix early wrapping of the command line when using git-prompt.sh and in a git repository

[rquadling]

No description provided.

[gitgitgadget]

Welcome to GitGitGadget

Hi @rquadling, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

• Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
• Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <[email protected]>, Ill Takalook <[email protected]>

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[gitgitgadget]

There are issues in commit eb1f7b8:
Fix early wrapping of the command line when using git-prompt.sh and in a git repository
Commit checks stopped - the message is too short
First line of commit message is too long (> 76 columns)
Commit not signed off

[dscho]

/allow

[gitgitgadget]

User rquadling is now allowed to use GitGitGadget.

[gitgitgadget]

There are issues in commit d1e4c63:
Fix early wrapping of the command line when using git-prompt.sh
Commit not signed off

[gitgitgadget]

There are issues in commit d1e4c63:
Fix early wrapping of the command line when using git-prompt.sh
Commit not signed off

[dscho]

Commit not signed off

@rquadling for details what this is all about, see https://git-scm.com/docs/SubmittingPatches#sign-off

[gitgitgadget]

There are issues in commit bae1e32:
Fix early wrapping of the command line when using git-prompt.sh
Commit not signed off

[gitgitgadget]

There are issues in commit 626324d:
Fix early wrapping of the command line when using git-prompt.sh
Commit not signed off

[briantracy]

I am a first time contributor, could you please /allow my PR: #1692

[rquadling]

I don't really see the point of using email as a way to submit a PR to a repo that has all the functionality already in play.

I found an issue, supplied a PR to the project responsible using a mechanism that is VERY VERY well understood.

Considering the PR is actually on a very remote aspect of the project, it's not worth my time having to subscribe to a mailing list, send one PR, wait for it to be merged, delete all the emails not related to the PR, unsubscribe when the PR is merged.

Considering I've got over 50,000 unread email ... it's all simply too much noise. The Git project has the PR. If they use it, then the issue gets solved. If they don't, then the issue and complaints, and links to gist detailing the fix locally which will get overwritten every time there's an upgrade will just continue.

[dscho]

The Git project has the PR.

That's incorrect, @rquadling. GitGitGadget is merely a tool trying to help, it is not run by the Git project itself. Therefore, nobody of the Git project had a look at your patch yet, they did not even see it.

[rquadling]

So what's next? is the PR going to continue on a path to be reviwed/accepted/rejected?

[dscho]

So what's next? is the PR going to continue on a path to be reviwed/accepted/rejected?

The PR won't go anywhere unless you /submit it, as described here.