Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completion: change short redirected url for full url #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bash completion: change short redirected url for full url #154

wants to merge 1 commit into from

Conversation

xverges
Copy link

@xverges xverges commented Nov 23, 2017

http://git.io/vfhol returns a redirect. That could be solved with curl -L. However, for something that goes into the bash profile, I think that it is a good thing to download it with a descriptive https url

@hemanth
Copy link
Contributor

hemanth commented Nov 23, 2017

git.io/git-completion would have been better, can't change it now, AFAIK.

@xverges
Copy link
Author

xverges commented Nov 24, 2017

If you are happy with the URL, you'll need to add the -L param to curl, to handle the shortened redirect.

@hemanth
Copy link
Contributor

hemanth commented Nov 24, 2017

Okies

mvolz added a commit to mvolz/tips that referenced this pull request Nov 5, 2018
As per the comments in git-tips#154, use -L to follow the redirect for curl. The tip as written does not currently work as it downloads the html for the redirect page instead.
mvolz added a commit to mvolz/tips that referenced this pull request Nov 5, 2018
As per git-tips#154, change to -L so that the redirect gets followed. As written this line downloads the html redirect page.
blanjatest2 pushed a commit to blanjatest2/tips that referenced this pull request Apr 15, 2020
As per git-tips#154, change to -L so that the redirect gets followed. As written this line downloads the html redirect page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants