Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current template lacks fsproj items needed to run in official ASP.NET docker containers #487

Open
lukemcdo opened this issue Jul 5, 2021 · 4 comments
Labels
documentation Request to change or extend documentation

Comments

@lukemcdo
Copy link

lukemcdo commented Jul 5, 2021

Hello,

While I don't know if the Giraffe team would prefer to update the template or update the docs, currently the fsproj file needs the following lines added in order to run in the official ASP.NET Docker containers:

<Project Sdk="Microsoft.NET.Sdk.Web">
  <PropertyGroup>
    <!-- Previous items in the first property group -->
    **<AspNetCoreHostingModel>OutOfProcess</AspNetCoreHostingModel>
    <AspNetCoreModuleName>AspNetCoreModuleV2</AspNetCoreModuleName>**
  </PropertyGroup>

I don't know what the oldest version of .NET Core and ASP.NET Core that support these two is, but I know they work in ASP.NET 3.1.

@dustinmoris dustinmoris added the documentation Request to change or extend documentation label Nov 14, 2021
@dustinmoris
Copy link
Member

Oh, thanks for bringing this to our attention! Have you got a pointer to an official ASP.NET Core documentation section which outlines why or when one needs this in order to work with the .NET Docker image? I'll add that to the docs then!

@lukemcdo
Copy link
Author

I mean, the in-process part is a bit confusing, but it doesn't seem like it ever runs on Linux or Mac -- the best case is that on those platforms, ASP.NET might not respect the setting: https://docs.microsoft.com/en-us/aspnet/core/host-and-deploy/iis/in-process-hosting?view=aspnetcore-6.0

AspNetCoreModuleV1 is deprecated, so that's why that one should change.

OutOfProcess hosting works with IIS, but with slightly reduced performance. InProcess does not run on Linux or Mac at all, from what I can tell.

@64J0
Copy link
Member

64J0 commented Sep 5, 2023

Up.

Do you guys still think this is something we can add to the documentation?

@surferjeff
Copy link

I hit this issue in my first 10 minutes of learning F# & Giraffe. Quite baffling to a newbie. Yes, I ran dotnet publish -c Release in the first 10 minutes because I wanted to see the size of a simple Giraffe App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request to change or extend documentation
Projects
None yet
Development

No branches or pull requests

4 participants