Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wrk2 arm compatible #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tbbharaj
Copy link

Trying to compile wrk2 on arm, generates following error:

lj_arch.h:279:2: error: #error "No target architecture defined"
 #error "No target architecture defined"

Upgraded LuaJIT to 2.1 to make wrk2 arm compatible.
Also added few minor changes to hdr_histogram.c script.c wrk.c to make it compile

@tbbharaj tbbharaj force-pushed the wrk2-a64-support branch from 8accadc to 60490fd Compare May 13, 2021 16:25
@tbbharaj tbbharaj changed the title Make wrk2 aarch64 compatible Make wrk2 arm compatible May 13, 2021
@tbbharaj tbbharaj marked this pull request as ready for review May 13, 2021 16:44
@tbbharaj
Copy link
Author

Wanted to followup on this PR to get wrk2 compiled on aarch64

@raguiar9080
Copy link

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it.
Appreciate the time, thanks for any help 👍

@tbbharaj
Copy link
Author

tbbharaj commented Oct 12, 2021

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

@raguiar9080
Copy link

@tbbharaj Is there a way to get this branch installed locally? I'm a bit of a noob regarding brew but I saw no way to do it. Appreciate the time, thanks for any help 👍

Are you able to clone this repo/branch?

Just to give you a point of situation, I can and did clone the branch, but then ran into several issues while trying to build it (openssl include files followed by a malformed Mach-o file).

I just went and ran a linux container to install normally since my purpose is just perform some tests. Thanks for the help 👍

@tbbharaj
Copy link
Author

Wanted to followup on this PR. Happy to address any feedbacks/reviews

@tbbharaj
Copy link
Author

tbbharaj commented Jan 21, 2022

Wanted to followup on this PR, would love to see wrk2 supporting arm

@raguiar9080
Copy link

I've since moved away from this. I solved my issue by simply creating a docker container and doing things from the inside so I can't really provide any further feedback.

Best of luck 🙏

@sebpop
Copy link

sebpop commented Mar 30, 2022

Hi,
who can review and merge this patch?
With this patch I can build and use wrk2 on arm64.

Thanks!

@orefalo
Copy link

orefalo commented Apr 14, 2022

thank you.
sorry to ask, I am a newbie.
I see no configure script.
and when I run make, i get

Apple clang version 13.1.6 (clang-1316.0.21.2.3)
Target: arm64-apple-darwin21.4.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

i did brew install gcc but then it's not picked up

@orefalo
Copy link

orefalo commented Jun 21, 2022

found this guy https://github.com/AppsFlyer/wrk3

@AGSaidi
Copy link

AGSaidi commented Jul 16, 2022

any hope to get this reviewed and merged?

@outsinre
Copy link

For those, who would like to run wrk2 on Apple M1, please refer to https://github.com/outsinre/homebrew-wrk2.

@odidev
Copy link

odidev commented Sep 21, 2022

Team, Can we please merge this PR to make wrk2 compatible with arm64.

@RamaMalladiAWS
Copy link

Checking again... Can this patch be merged? Thanks.

@orefalo
Copy link

orefalo commented May 15, 2023

I switched to oha - https://github.com/hatoo/oha

recommended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants