Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solving problems with Flaky test in setDateSession method #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solving problems with Flaky test in setDateSession method #183

wants to merge 1 commit into from

Conversation

augustocristian
Copy link
Contributor

This PR closes #182
The problem with the date was caused by the Java Date class. The current implementation of this class when you retrieve the Data.MONTH, returns a number between 0 and 11. The current implementation was not valid for this case, this PR contains:

  • An improvement of the setDateSession method, that removes the getAttribute deprecated method, considers the locale (to ease LocalTesting, and checks using the YYYY-MM-DD format that is the one that is stored by default in the DatePicker
  • Some minor changes in variable naming, to follow the Java conventions (Sonar)

@augustocristian augustocristian linked an issue Jan 1, 2025 that may be closed by this pull request
Flaky test into the sessionTest setDateSession() method #182
Open
@augustocristian augustocristian mentioned this pull request Jan 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiertuya javiertuya Awaiting requested review from javiertuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky test into the sessionTest setDateSession() method
1 participant
@augustocristian