Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider default values in cluster charts #3584

Open
1 task
yulianedyalkova opened this issue Jul 18, 2024 · 1 comment
Open
1 task

Reconsider default values in cluster charts #3584

yulianedyalkova opened this issue Jul 18, 2024 · 1 comment
Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service team/turtles Team Turtles topic/releases About how we treat our own releases

Comments

@yulianedyalkova
Copy link

yulianedyalkova commented Jul 18, 2024

With the new releases flow, a lot of the values in our cluster chart get overwritten by the values in the release file. Let's either remove those or make it explicit as currently it's a bit confusing (thread).

Initial scope:

  • Clearly document which values get overwritten and not used anymore for both CAPA and CAPZ
@yulianedyalkova yulianedyalkova converted this from a draft issue Jul 18, 2024
@yulianedyalkova yulianedyalkova added area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service topic/releases About how we treat our own releases team/turtles Team Turtles labels Jul 18, 2024
@Gacko Gacko moved this from Inbox 📥 to Backlog 📦 in Roadmap Jul 22, 2024
@nprokopic
Copy link

Different providers still have different levels of integration with cluster chart, and not all of them still use new releases, so eventhough some default values are not used any more by e.g. cluster-aws / CAPA, they could be still used by other providers.

e.g. The default k8s version in the schema is used by providers that use cluster chart, but do not use new releases. Until last week that was still CAPZ (which is still on 1.25), and I think CAPZ still needs that, since v25 with new releases is not yet merged giantswarm/releases#1296.

We also have a helper in cluster chart for getting a Kubernetes version https://github.com/giantswarm/cluster/blob/6017f6ed54d4152df6df94d5dbf04dae2c72e502/helm/cluster/templates/_helpers.tpl#L368. We are already using this in cluster-aws and now/soon in cluster-azure. This helper func will get k8s version form either Release CR or from Helm values, depending on if the provider is using new releases or not. Unfortunately this (and some other similar "public" helpers) is not yet documented in some more visible place. We can do this and maybe have some docs about these in cluster chart README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kaas Mission: Cloud Native Platform - Self-driving Kubernetes as a Service team/turtles Team Turtles topic/releases About how we treat our own releases
Projects
Status: Backlog 📦
Development

No branches or pull requests

2 participants