From 8c98d7fb6e621ffd7c79c95f173e492b4ea56ae9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20Nicol?= <hervenicol@users.noreply.github.com>
Date: Fri, 6 Oct 2023 10:59:31 +0200
Subject: [PATCH] Prometheus dashboard: fix node RAM (#375)

Co-authored-by: Herve Nicol <12008875+hervenicol@users.noreply.github.com>
---
 CHANGELOG.md                                             | 4 ++++
 helm/dashboards/dashboards/shared/public/prometheus.json | 5 ++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c47d645e..3dced82c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+
+- Prometheus dashboard: fix node RAM
+
 ### Added
 
 - Add custom dashboards documentation link into home panel.
diff --git a/helm/dashboards/dashboards/shared/public/prometheus.json b/helm/dashboards/dashboards/shared/public/prometheus.json
index 8757e782..ded376c1 100644
--- a/helm/dashboards/dashboards/shared/public/prometheus.json
+++ b/helm/dashboards/dashboards/shared/public/prometheus.json
@@ -48,7 +48,6 @@
   "editable": true,
   "fiscalYearStartMonth": 0,
   "graphTooltip": 1,
-  "id": 67,
   "links": [
     {
       "asDropdown": false,
@@ -935,7 +934,7 @@
             "uid": "PBFA97CFB590B2093"
           },
           "editorMode": "code",
-          "expr": "max (node_memory_MemTotal_bytes{node=~\".+\"} * on (node) group_right(pod) (kube_pod_info{pod=~\"prometheus-.*-0\",cluster_type=\"management_cluster\", namespace=~\"($cluster)-prometheus\"})) by (namespace)",
+          "expr": "max (node_memory_MemTotal_bytes{node=~\".+\", cluster_type=\"management_cluster\"} * on (node) group_right(pod) (kube_pod_info{pod=~\"prometheus-.*-0\",cluster_type=\"management_cluster\", namespace=~\"($cluster)-prometheus\"})) by (namespace)",
           "hide": false,
           "legendFormat": "node memory - {{ namespace }}",
           "range": true,
@@ -1775,6 +1774,6 @@
   "timezone": "UTC",
   "title": "Prometheus",
   "uid": "iWowmlSmk",
-  "version": 1,
+  "version": 4,
   "weekStart": ""
 }